LGTM3 On Fri, Feb 14, 2025 at 3:50 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 2/13/25 11:30 AM, Chris Harrelson wrote: > > LGTM1 > > On Thu, Feb 13, 2025 at 7:38 AM Shu-yu Guo <s...@chromium.org> wrote: > >> Yep, shipping Float16Array will make those tests pass. There is virtual >> test suite you can see that has the updated expectations once the feature >> ships. E.g. here's fetch's response-headers tests >> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/virtual/float16array-enabled/external/wpt/fetch/api/basic/request-headers.any-expected.txt;drc=ec42d9a27be16cfee08490a1db43924d375cfab1> >> . >> >> On Wed, Feb 12, 2025 at 8:55 PM Domenic Denicola <dome...@chromium.org> >> wrote: >> >>> On Thursday, February 13, 2025 at 12:21:13 PM UTC+9 Chromestatus wrote: >>> >>> Contact emails s...@chromium.org, seo...@chromium.org >>> >>> Explainer None >>> >>> Specification https://tc39.es/proposal-float16array >>> >>> Summary >>> >>> Adds the Float16Array typed array. Number values are rounded to IEEE >>> fp16 when writing into Float16Array instances. >>> >>> >>> Blink component Blink>JavaScript>Language >>> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EJavaScript%3ELanguage%22> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> None. >>> >>> >>> *Gecko*: Shipped/Shipping (https://www.mozilla.org/en- >>> US/firefox/129.0/releasenotes) >>> >>> *WebKit*: Shipped/Shipping (https://developer.apple.com/ >>> documentation/safari-technology-preview-release-notes/stp-release-202) >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> Debuggable like the existing typed array constructors >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> In test262: https://github.com/tc39/test262/pull/3849 >>> >>> >>> Note that there are also a good number of WPTs that check that >>> Float16Arrays are supported in web APIs. For example, >>> https://wpt.fyi/results/WebCryptoAPI/getRandomValues.any.html?label=experimental&label=master&aligned >>> or >>> https://wpt.fyi/results/fetch/api/basic/request-headers.any.html?label=experimental&label=master&aligned >>> . >>> >>> Canary with experimental web platform features is currently failing >>> these. Can you confirm that shipping Float16Array per this Intent will be >>> enough to make these pass? Or would there be additional work necessary? >>> >>> >>> >>> Flag name on about://flags --js-float16array >>> >>> Finch feature name V8Flag_js_float16array >>> >>> Requires code in //chrome? False >>> >>> Tracking bug https://issues.chromium.org/issues/42203953 >>> >>> Estimated milestones Shipping on desktop 135 DevTrial on desktop 124 >>> Shipping >>> on Android 135 DevTrial on Android 124 Shipping on WebView 135 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status https://chromestatus.com/ >>> feature/5164400693215232?gate=6205029258887168 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com>. >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e-QmU6qAKA7kuBM25Wr3kDfrWhjUMXWLMmrMvNZ-OtkGQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e-QmU6qAKA7kuBM25Wr3kDfrWhjUMXWLMmrMvNZ-OtkGQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8gsaQS3fvA-SjHD7o4Gji9b0_EpzGsaVC8L5ujnCCCHg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8gsaQS3fvA-SjHD7o4Gji9b0_EpzGsaVC8L5ujnCCCHg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_sErz97J7fav59qvM%2BqEM%3DUOMHTjp82%2BzCc1M6iesA3Q%40mail.gmail.com.
