LGTM3

/Daniel

On 2025-03-19 03:51, Vladimir Levin wrote:
LGTM2

Is there really no Finch flag here, or is it just not recorded in the email? I'd recommend we have a flag as a risk mitigation.

Thanks,
Vlad

On Tuesday, March 18, 2025 at 8:32:02 AM UTC-4 Mike Taylor wrote:

    LGTM1

    On 3/17/25 8:55 PM, Chromestatus wrote:


            Contact emails

    chris...@chromium.org


            Explainer

    None


            Specification

    https://drafts.csswg.org/css-color-adjust/#propdef-print-color-adjust
    <https://drafts.csswg.org/css-color-adjust/#propdef-print-color-adjust>



            Summary

    The print-color-adjust allows adjusting colors in printed web
    pages. This is the same as Chromium's already-supported
    -webkit-print-color-adjust, but with a standardized name. The
    -webkit-prefixed version is not removed.
    https://developer.mozilla.org/en-US/docs/Web/CSS/print-color-adjust
    <https://developer.mozilla.org/en-US/docs/Web/CSS/print-color-adjust>



            Blink component

    Blink>Layout>Printing
    
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ELayout%3EPrinting%22>



            TAG review

    N/A (shipping a feature already standardized and shipped in other
    browser engines)


            TAG review status

    Not applicable


            Risks



            Interoperability and Compatibility

    None - the other engines already support this property.



    /Gecko/: Shipped/Shipping

    /WebKit/: Shipped/Shipping

    /Web developers/: No signals

    /Other signals/:


            Ergonomics

    None



            Activation

    None



            Security

    None



            WebView application risks

    Does this intent deprecate or change behavior of existing APIs,
    such that it has potentially high risk for Android WebView-based
    applications?

    None



            Debuggability

    None



            Will this feature be supported on all six Blink platforms
            (Windows, Mac, Linux, ChromeOS, Android, and Android
            WebView)?

    Yes


            Is this feature fully tested by web-platform-tests
            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

    Yes

    https://wpt.fyi/results/css/css-color-adjust/inheritance.html
    <https://wpt.fyi/results/css/css-color-adjust/inheritance.html>
    https://wpt.fyi/results/css/css-color-adjust/parsing/print-color-adjust.html
    
<https://wpt.fyi/results/css/css-color-adjust/parsing/print-color-adjust.html>




            Flag name on about://flags

    None


            Finch feature name

    None


            Non-finch justification

    It's just unprefixing a simple CSS feature for printing already
    supported in other browser engines, which is not risky.



            Requires code in //chrome?

    False


            Tracking bug

    https://issues.chromium.org/376381169
    <https://issues.chromium.org/376381169>


            Availability expectation

    Feature is available on Web Platform Baseline


            Adoption plan

    Ship it


            Estimated milestones

    Shipping on desktop         136
    Shipping on Android         136
    Shipping on WebView         136



            Anticipated spec changes

    Open questions about a feature may be a source of future web
    compat or interop issues. Please list open issues (e.g. links to
    known github issues in the project for the feature specification)
    whose resolution may introduce web compat/interop risk (e.g.,
    changing to naming or structure of the API in a
    non-backward-compatible way).

    The color-adjust shorthand is defined in the spec but marked as
    deprecated. For that reason, this intent does *not* ship that
    shorthand.


            Link to entry on the Chrome Platform Status

    https://chromestatus.com/feature/5159639697850368?gate=5151598806040576
    <https://chromestatus.com/feature/5159639697850368?gate=5151598806040576>


    This intent message was generated by Chrome Platform Status
    <https://chromestatus.com>.
-- You received this message because you are subscribed to the
    Google Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org
    <mailto:blink-dev+unsubscr...@chromium.org>.
    To view this discussion visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67d8c47d.2b0a0220.1cd73d.0b7d.GAE%40google.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/67d8c47d.2b0a0220.1cd73d.0b7d.GAE%40google.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/20b03354-366a-4b1d-944a-55c5f4491acan%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/20b03354-366a-4b1d-944a-55c5f4491acan%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/7e9463b8-f758-4811-a090-3d27eea7c940%40gmail.com.

Reply via email to