LGTM3 On Wednesday, April 2, 2025 at 8:28:54 AM UTC-7 sligh...@chromium.org wrote:
> LGTM2 > > On Wednesday, April 2, 2025 at 6:57:22 AM UTC-7 Daniel Bratell wrote: > >> LGTM1 >> >> /Daniel >> On 2025-04-01 00:11, Di Zhang wrote: >> >> Contact emails >> >> dizh...@chromium.org >> >> Explainer >> >> None >> >> Specification >> >> https://www.w3.org/TR/css-display-4 >> >> Summary >> >> The reading-flow CSS property controls the order in which elements in a >> flex, grid or block layout are exposed to accessibility tools and focused >> via TAB keyboard focus navigation. >> >> This change implements the CSS reading-flow keyword values: >> >> * normal >> >> * flex-visual >> >> * flex-flow >> >> * grid-rows >> >> * grid-columns >> >> * grid-order >> >> * source-order >> >> See spec: https://drafts.csswg.org/css-display-4/#reading-flow >> >> The reading-order CSS property allows authors to manually-override the >> order within a reading flow container. It is an integer with default value >> 0. >> >> See spec: https://drafts.csswg.org/css-display-4/#reading-order >> >> Please find more thorough examples of how TAB keyboard navigation and >> accessibility is improved by this feature here: >> >> https://chrome.dev/reading-flow-examples/ >> >> >> Blink component >> >> Blink>HTML>Focus >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EHTML%3EFocus%22> >> >> Search tags >> >> reading-flow <https://chromestatus.com/features#tags:reading-flow>, >> reading-order <https://chromestatus.com/features#tags:reading-order> >> >> TAG review >> >> https://github.com/w3ctag/design-reviews/issues/978 >> >> TAG review status >> >> Issues addressed >> >> Risks >> >> Interoperability and Compatibility >> >> None >> >> >> Gecko: No signal ( >> https://github.com/mozilla/standards-positions/issues/1056) >> Editors/Implementers are actively discussing in W3C working groups, but >> have not commented on the position issue yet. >> >> WebKit: No signal ( >> https://github.com/WebKit/standards-positions/issues/378) >> Editors/Implementers are actively discussing in W3C working groups, but >> have not commented on the position issue yet. >> >> Web developers: No signals >> >> Other signals: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> No, this is only shipping new CSS properties without modifying existing >> behavior. >> >> >> Debuggability >> >> None >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? >> >> Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? >> >> Yes >> >> >> https://wpt.fyi/results/shadow-dom/focus-navigation/reading-flow/tentative?label=experimental&label=master&aligned >> >> >> Flag name on about://flags >> >> CSSReadingFlow >> >> Finch feature name >> >> CSSReadingFlow >> >> Requires code in //chrome? >> >> False >> >> Tracking bug >> >> https://issues.chromium.org/issues/40932006 >> >> Availability expectation >> >> Should be usable for any Chromium browsers that support keyboard focus >> navigation or uses Accessibility tree to navigate between accessibility >> nodes. >> >> Adoption expectation >> >> Enabled by default. >> >> Sample links >> >> https://chrome.dev/reading-flow-examples >> >> Estimated milestones >> >> Shipping on desktop >> >> 137 >> >> DevTrial on desktop >> >> 128 >> >> Shipping on Android >> >> 137 >> >> Shipping on WebView >> >> 137 >> >> >> Anticipated spec changes >> >> Per resolution with CSS WG [1], we have implemented the agreed CSS >> properties, values, name choices and behavior. There might be changes in >> the future, but there is no active proposal for that yet. >> >> [1] >> https://github.com/w3c/csswg-drafts/issues/11396#issuecomment-2755105190 >> >> The HTML specification to update the focus navigation scoping has >> consensus and an LGTM. It is not merged yet because of disagreement on the >> stability on the CSS side. We do not expect significant changes. >> >> https://github.com/whatwg/html/pull/10613 >> >> Link to entry on the Chrome Platform Status >> >> https://chromestatus.com/feature/5113638848561152?gate=5595647291162624 >> >> Links to previous Intent discussions >> >> Intent to Prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2BSS7eDCZgA2GbReQzyfjHj3OGYgqr9m%3Dg%2BAgu4b%2B2V8ffxSnQ%40mail.gmail.com >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> >> >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/73d17866-43ba-484a-8c1f-33ae36a7687dn%40chromium.org >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/73d17866-43ba-484a-8c1f-33ae36a7687dn%40chromium.org?utm_medium=email&utm_source=footer> >> . >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/33efa640-e0aa-4600-abaa-2df919ae0479n%40chromium.org.