Thanks! FYI, I'm ready to ship this in M137, I thought it was going to take longer! Please let me know if there are any issues with doing so.
On Mon, Apr 14, 2025 at 7:17 PM Chris Harrelson <chris...@chromium.org> wrote: > LGTM3 > > On Mon, Apr 14, 2025 at 11:17 AM 'Daniel Clark' via blink-dev < > blink-dev@chromium.org> wrote: > >> For the record, the TAG did review this (Resolution: satisfied): >> https://github.com/w3ctag/design-reviews/issues/1033. LGTM2. >> >> >> >> -- Dan >> >> >> >> *From:* Domenic Denicola <dome...@chromium.org> >> *Sent:* Sunday, April 13, 2025 10:00 PM >> *To:* Noam Rosenthal <nrosent...@chromium.org> >> *Cc:* Domenic Denicola <dome...@chromium.org>; blink-dev < >> blink-dev@chromium.org> >> *Subject:* [EXTERNAL] [blink-dev] Re: Intent to implement and ship: >> Support offset-path: shape() >> >> >> >> Thanks, LGTM1. Sorry about the milestone confusion, I guess I was >> thinking of 136... >> >> >> >> On Fri, Apr 11, 2025 at 5:34 PM Noam Rosenthal <nrosent...@chromium.org> >> wrote: >> >> Sorry, I realized I forgot to tick a few ChromeStatus boxes. >> >> >> >> On Fri, Apr 11, 2025 at 6:12 AM Domenic Denicola <dome...@chromium.org> >> wrote: >> >> >> >> On Wednesday, April 9, 2025 at 5:17:32 PM UTC+9 Noam Rosenthal wrote: >> >> Contact emailsnrosent...@chromium.org >> >> ExplainerNone >> >> Specificationhttps://drafts.csswg.org/css-shapes-2/#shape-function >> >> Summary >> >> The shape() function is already supported in clip-path, and allows >> responsive clipping. Enabling it also for offset-path will close a small >> gap where the same kind of shape can be used for that property as well. >> >> >> >> * (already works in Safari and covered by WPTs) >> >> >> >> Blink componentBlink>CSS >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ECSS%22> >> >> TAG reviewNone >> >> TAG review statusNot applicable >> >> Risks >> >> >> >> Interoperability and Compatibility >> >> None >> >> >> >> *Gecko*: No signal >> >> >> >> Can you file for one? Or maybe this is small enough not to require one, >> but is there a recorded CSSWG resolution with Gecko participation you could >> link to? >> >> There was one already open ( >> https://github.com/mozilla/standards-positions/issues/1153) >> >> >> >> >> *WebKit*: Shipped/Shipping >> >> *Web developers*: No signals >> >> *Other signals*: >> >> WebView application risks >> >> *Does this intent deprecate or change behavior of existing APIs, such >> that it has potentially high risk for Android WebView-based applications?* >> >> None >> >> >> >> Debuggability >> >> None >> >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)?No >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?No >> >> >> >> Why not? >> >> Sorry, I just missed a few boxes in ChromeStatus, this is supported on >> all platforms and fully tested by WPT. >> >> >> >> >> >> >> >> Flag name on about://flagsNone >> >> Finch feature nameNone >> >> Non-finch justificationNone >> >> >> >> Please provide one of these two, preferably the Finch feature name. >> >> It's there, updated ChromeStatus (it has a regular runtime flag which can >> be finched). >> >> >> >> >> >> Rollout planWill ship enabled for all users >> >> Requires code in //chrome?False >> >> Tracking bughttps://issues.chromium.org/issues/389713717 >> >> Estimated milestonesShipping on desktop138Shipping on Android138Shipping >> on WebView138 >> >> >> >> 138 has already branched, so just checking that you intend to backport? >> Or if not, it'd be good to update this to 139. >> >> According to https://chromiumdash.appspot.com/schedule 138 branches in >> May. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra8dU7_5rBnTSvdfN2Ku%3DtA4F%2BLwxVXWW%3Dkim1tcJRgXKA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra8dU7_5rBnTSvdfN2Ku%3DtA4F%2BLwxVXWW%3Dkim1tcJRgXKA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CH4PR00MB23295689587184B492B16FBFC5B32%40CH4PR00MB2329.namprd00.prod.outlook.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CH4PR00MB23295689587184B492B16FBFC5B32%40CH4PR00MB2329.namprd00.prod.outlook.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYbJtXY_CPkdQrK-K0Az75UD3RiKbbCusAahJc3naWLqXA%40mail.gmail.com.
