LGTM3

On 10/24/25 3:22 a.m., 'Philip Jägenstedt' via blink-dev wrote:
Great, thank you Chris!

On Fri, Oct 24, 2025 at 9:03 AM Christopher Cameron <[email protected]> wrote:

    I've updated the CSS gradient tests for this here:
    https://chromium-review.googlesource.com/c/chromium/src/+/7077316

    There are also canvas gradient WPT tests (which is a feature that
    hasn't made it into the spec yet). I've updated the tests and our
    (speculative) implementation to include display-p3-linear.


    On Thu, Oct 23, 2025 at 8:07 AM Philip Jägenstedt
    <[email protected]> wrote:

        Good catch, gradients in linear color space is a very
        plausible use case that we should test. Chris, can you add a
        test for this? I presume there are other tests that can be copied.

        Den tors 23 okt. 2025 06:00一丝 <[email protected]> skrev:

            It appears the new color space in WPT still lacks testing
            for CSS gradients. Could this be added?

            e.g.

            `background-image: linear-gradient(to right in
            display-p3-linear, red, blue);`



            在2025年10月22日星期三 UTC+8 23:22:36<Chris Harrelson> 写道:

                LGTM2

                On Wed, Oct 22, 2025 at 7:08 AM 'Philip Jägenstedt'
                via blink-dev <[email protected]> wrote:

                    I had a chat with Chris about this.

                    https://chromestatus.com/feature/5162372125818880
                    has been updated to link to the spec, and a
                    standards position for Mozilla was filed:
                    
https://drafts.csswg.org/css-color/#predefined-display-p3-linear
                    https://github.com/mozilla/standards-positions/issues/1311

                    This already landed in WebKit:
                    
https://github.com/WebKit/WebKit/commit/40fca09d9ff83420031aa4cda7e0553e3b7a13fc
                    
https://wpt.fyi/results/css/css-color?label=master&label=experimental&aligned&q=display-p3-linear
                    
<https://wpt.fyi/results/css/css-color?label=master&label=experimental&aligned&q=display-p3-linear>
                    (the failure of display-p3-linear-006.html is only
                    off by 1 for a bunch of pixels)

                    So I think this is quite a straightforward case,
                    LGTM1!

                    On Wed, Oct 22, 2025 at 3:06 PM Daniel Bratell
                    <[email protected]> wrote:

                        The page at
                        
https://www.chromium.org/blink/guidelines/web-platform-changes-guidelines
                        lists most of the things we want to know
                        before sending a feature out into the wild
                        wild world.

                        One of the main questions regards
                        compatibility. We want what we do to end up in
                        a web where browsers agree on how something
                        should be rendered which is why we typically
                        require new features to probe Mozilla and
                        WebKit through their web standards positions
                        (unless they have already shipped).

                        Another aspect of compatibility, and risk, is
                        about web compatibility. Will this change
                        break things? Are we really, really sure? That
                        is why we typically require every feature to
                        have a finch flag so that at least Google
                        Chrome can turn off something that causes
                        unexpected problems.

                        When I say "typical", it's because no rule
                        fits all, but then we instead need to know why
                        a certain rule does not apply.

                        You will also see that we ask for some info
                        texts, explainer, specification, that many
                        implementers consider obvious. Often it is not
                        obvious for other people though, and these
                        texts end up in official blog posts and in
                        other external communication.

                        /Daniel

                        On 2025-10-22 12:41, Christopher Cameron wrote:
                        Let me know what questions you have.

                        Indeed, almost everything is N/A (I've filled
                        them out in the feature if you want to look).

                        On Wed, Oct 22, 2025 at 12:20 PM Daniel
                        Bratell <[email protected]> wrote:

                            The form seems fields seem to be mostly
                            left empty. I don't think anything should
                            be empty (though a N/A may fit some
                            things). I have questions, but they would
                            mostly be answered by filling in the form
                            and re-posting it.

                            /Daniel

                            On 2025-10-22 11:58, 'Christopher
                            Cameron' via blink-dev wrote:
                            Hello blink-dev!

                            This very simple feature adds
                            display-p3-linear as a CSS color space.
                            This has been added to the CSS
                            specification and has a bazillion WPT
                            tests from:
                            https://github.com/w3c/csswg-drafts/issues/12596
                            It has been requested as a candidate for
                            interop 2026:
                            
https://github.com/web-platform-tests/interop/issues/1167
                            *
                            *
                            More relevant to the topics close to my
                            heart are the fact that this is a very
                            good space for physically based
                            rendering and high dynamic range. Adding
                            this space to the list of canvas spaces
                            is a separate feature over at:
                            https://chromestatus.com/feature/5122501071994880


                            *Contact emails*
                            [email protected]

                            *Specification*
                            /No information provided/

                            *Summary*
                            Add display-p3-linear CSS color space

                            *Blink component*
                            Blink>CSS
                            
<https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3ECSS%22>

                            *Web Feature ID*
                            color-function
                            <https://webstatus.dev/features/color-function>

                            *Motivation*
                            /No information provided/

                            *Initial public proposal*
                            /No information provided/

                            *TAG review*
                            /No information provided/

                            *TAG review status*
                            Not applicable

                            *Risks*


                            *Interoperability and Compatibility*
                            /No information provided/

                            /Gecko/: No signal

                            /WebKit/: No signal

                            /Web developers/: No signals

                            /Other signals/:

                            *WebView application risks*

                            Does this intent deprecate or change
                            behavior of existing APIs, such that it
                            has potentially high risk for Android
                            WebView-based applications?

                            /No information provided/


                            *Debuggability*
                            /No information provided/

                            *Will this feature be supported on all
                            six Blink platforms (Windows, Mac,
                            Linux, ChromeOS, Android, and Android
                            WebView)?*
                            No

                            *Is this feature fully tested by
                            web-platform-tests
                            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?*
                            No


                            *Flag name on about://flags*
                            /No information provided/

                            *Finch feature name*
                            /No information provided/

                            *Non-finch justification*
                            /No information provided/

                            *Rollout plan*
                            Will ship enabled for all users

                            *Requires code in //chrome?*
                            False

                            *Estimated milestones*

                            No milestones specified



                            *Anticipated spec changes*

                            Open questions about a feature may be a
                            source of future web compat or interop
                            issues. Please list open issues (e.g.
                            links to known github issues in the
                            project for the feature specification)
                            whose resolution may introduce web
                            compat/interop risk (e.g., changing to
                            naming or structure of the API in a
                            non-backward-compatible way).

                            /No information provided/

                            *Link to entry on the Chrome Platform
                            Status*
                            
https://chromestatus.com/feature/5162372125818880?gate=4761603400663040

                            This intent message was generated by
                            Chrome Platform Status
                            <https://chromestatus.com/>.
-- You received this message because you
                            are subscribed to the Google Groups
                            "blink-dev" group.
                            To unsubscribe from this group and stop
                            receiving emails from it, send an email
                            to [email protected].
                            To view this discussion visit
                            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnfxj9fo12y5zfJ_TosXUU6LaQ6CAcRSX6nqBGnMUWvHZST9w%40mail.gmail.com
                            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnfxj9fo12y5zfJ_TosXUU6LaQ6CAcRSX6nqBGnMUWvHZST9w%40mail.gmail.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are
                    subscribed to the Google Groups "blink-dev" group.
                    To unsubscribe from this group and stop receiving
                    emails from it, send an email to
                    [email protected].

                    To view this discussion visit
                    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYe7BS72Ua6q9gXt7OxqS%3DCEV%2BhxtMSknXzaAZhu1N_Fpg%40mail.gmail.com
                    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYe7BS72Ua6q9gXt7OxqS%3DCEV%2BhxtMSknXzaAZhu1N_Fpg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYf5Gohn8w%3DygNqTDZ-QQ5Xaq3iTzq1nuP-mB939Jy6wCw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYf5Gohn8w%3DygNqTDZ-QQ5Xaq3iTzq1nuP-mB939Jy6wCw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/bb069d3a-c111-463e-aa29-2a4fe801f974%40chromium.org.

Reply via email to