#330: Lazy evaluation of req.chrome
--------------------------+--------------------
Reporter: peter | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+--------------------
Comment (by olemis):
Replying to [comment:3 peter]:
> Replying to [comment:2 olemis]:
> > Replying to [ticket:330 peter]:
> > > For optimal performance req.chrome should be evaluated only if
necessary.
> > > This currently violated on multiple places in request handlers,
filters and mainly by trachacks:TracThemeEngine plugin.
> > >
> >
> > Could you please mention where is it exactly that
trachacks:ThemeEnginePlugin violates lazy instantiation of `req.chrome` ?
> >
[...]
>
> When the plugin is installed and active it's post_process_request() will
be invoked for every request. AFAICT there is nothing in that code that
would differentiate requests (API vs UI requests) so add_stylesheet() will
be called for all of them which then calls add_link() that evaluates
req.chrome.
>
I'll check that
;)
https://trac-hacks.org/ticket/10748
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/330#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
