OK, configuration is for a different ticket/email thread anyway.
Lightboxes likewise, although I expect I will have some alternative
suggestions around that.
Olemis: if you think that another solution is to use the oneliner wiki
formatter, could you test that assumption? If it is not quite right, it
sounds like we could create another wiki formatter. I expect that the
oneliner formatter would be in use when abbreviated_messages is
specified in the timeline section of the configuration.
Cheers,
Gary
On 19/12/12 16:21, Joachim Dreimann wrote:
Welcome Tom!
I don't believe resizing images is worth the hassle: On pictures for people
or objects they may still be recognisable in a meaningful way, but I don't
see that being the case the screenshots or other image types likely to be
attached to a software product -related ticket.
I like Gary's suggestion of a placeholder better: It still gives a clear
indication that there is an image attached (similar placeholders may be
used to indicate patches/diffs/documents). It would also provide a clear
click target from which users could expect a lightbox-style overlay view of
the actual image. Just displaying a link wouldn't make that as clear. I'd
also expect placeholders to be faster performance wise (being cacheable for
example).
As for users being able to modify/change those image settings: I suggest we
wait until that's requested by users and reassess it then, but don't build
it in from the beginning. Too many configuration options (even if each
seems sensible individually) make for a very complicated product.
Cheers,
Joe
On 19 December 2012 13:41, Tom Kitchin <[email protected]> wrote:
Whoops, seems email attachments don't get into mailing lists. I've pasted
the simple image hiding fix patch below. I'll look further into resizing
the image when I have time, though.
Index: bloodhound_theme/bhtheme/htdocs/bloodhound.css
===================================================================
--- bloodhound_theme/bhtheme/htdocs/bloodhound.css (revision 1423531)
+++ bloodhound_theme/bhtheme/htdocs/bloodhound.css (working copy)
@@ -144,6 +144,10 @@
}
+#activityfeed img {
+ display: none;
+}
+
#activityfeed dt {
font-weight: normal;
}
On 19 December 2012 13:15, Gary Martin <[email protected]> wrote:
Great to hear from you Tom!
I think for a quick solution I could live with not displaying in the
short
term. Alternatively, swapping the image for a placeholder image might
work.
I could see the visibility of images as being something configurable
though. For tall images, perhaps we could just scale them back to some
maximum height.
Cheers,
Gary
On 19/12/12 12:58, Peter Koželj wrote:
I am in favor of keeping images. Normally they should not be to heigh
when
resized to fit activity feed width.
In the long run I would like if users have an option on activity widget
or
in widget activity setting to show/hide images.
And...
... welcome to Bloodhound!
Peter
On 19 December 2012 13:05, Tom Kitchin <[email protected]> wrote:
Hi,
I've been reading the dev mailing list for a while, and I thought it
might
be a time to try and get involved. I took a look at ticket #279 (
https://issues.apache.org/**bloodhound/ticket/279<
https://issues.apache.org/bloodhound/ticket/279>),
in which images in
ticket descriptions turn up in the activity feed as well.
The first solution (not rendering them) is simple enough as far as I
can
see - I've attached a very simple patch which just sets them
display:none
in CSS.
I've been looking into the second solution (resizing the images to fit
instead of hiding them) as well. As far as I can tell (prompted by
Gary)
the trick would be to do something with the Image() macro in the
specific
context of the Activity feed to apply the 'span4' class to the img tag.
I
haven't quite worked out how to do that yet, but thought I'd send a
message
here before I persisted.
Which approach is preferred? As far as I can see, the question comes
down
to whether the activity feed could end up misinforming people due to
missing images, and whether it would look jarring if a referenced image
wasn't there. On the other hand, even resized images might still be
very
long, taking up a lot of space in the feed.
Incidentally, nice to meet you all. I hope I can be of some help with
the
project.
Tom
