Sorry Gagan, I didn't realize it earlier, but attachments are removed from mail list emails. I have a created a JIRA issue that you can post the patch. https://issues.apache.org/jira/browse/BLUR-43
Thanks! Aaron On Wed, Nov 7, 2012 at 7:59 AM, Aaron McCurry <[email protected]> wrote: > Thanks Gagan! I will take a look at it later today. > > Aaron > > > > On Wed, Nov 7, 2012 at 3:05 AM, Gagan Juneja <[email protected]>wrote: > >> Hi Aaron, >> I have created 2 profiles new now. >> 1. default : This profile run all the unit tests and skip Integration >> tests. >> 2. integration-test : This profile run only integration tests and skip >> unit tests. >> >> To segregate Integration tests and Unit tests, I made assumption that all >> our Integration tests should start with prefix "IT" e.g. >> BlurClusterTest.java which is an integration test should now be renamed to >> ITBlurClusterTest.java. We can change this configuration as per convenience. >> >> I was not able to test these profile thoroughly because of some tests and >> compilation failures. Even though I did some sniff tests to check these >> profiles. Please let me know in case you find any issues. I am attaching >> here the patch, please review and let me know your feedback. >> >> >> Regards, >> Gagan >> >> >> On Wed, Nov 7, 2012 at 8:04 AM, Aaron McCurry <[email protected]> wrote: >> >>> I have pushed the branch 0.2-dev-removing-old-thrift where I am removing >>> the old thrift objects. There are still several broken projects, I will >>> continue to update over the next few days. Thanks! >>> >>> Aaron >>> >>> >>> >>> On Tue, Nov 6, 2012 at 10:16 AM, Aaron McCurry <[email protected]> >>> wrote: >>> >>> > I think the BlurClusterTest is for sure an integration test. As we >>> > identify others we can move them into the integration tests. >>> > >>> > Thanks, >>> > Aaron >>> > >>> > >>> > >>> > On Tue, Nov 6, 2012 at 9:50 AM, Gagan Juneja < >>> [email protected]>wrote: >>> > >>> >> Hi Aaron, >>> >> One quick question. How to identify which test cases are Integration >>> Tests >>> >> and Which are Unit Tests means any package/project level segregation. >>> >> >>> >> Regards, >>> >> Gagan >>> >> >>> >> On Tue, Nov 6, 2012 at 7:36 PM, Aaron McCurry <[email protected]> >>> wrote: >>> >> >>> >> > That would great! Thanks. >>> >> > >>> >> > Sent from my iPhone >>> >> > >>> >> > On Nov 5, 2012, at 11:05 PM, Gagan Juneja < >>> [email protected]> >>> >> > wrote: >>> >> > >>> >> > > Hi Aaron, >>> >> > > We generally use Maven Failsafe plugin to separate integration >>> tests >>> >> from >>> >> > > unit tests. I can help you in this if required. >>> >> > > >>> >> > > >>> >> > > Regards, >>> >> > > Gagan >>> >> > > >>> >> > > On Tue, Nov 6, 2012 at 9:23 AM, Scott Leberknight < >>> >> [email protected] >>> >> > >wrote: >>> >> > > >>> >> > >> I think you'd probably have to use Maven profiles, e.g. separate >>> >> > profiles >>> >> > >> one for unit tests and one for integration tests. And then you'd >>> >> > probably >>> >> > >> need to mess around with includes/excludes in the Surefire >>> plugin. >>> >> > >> >>> >> > >> >>> >> > >> On Mon, Nov 5, 2012 at 10:16 PM, Aaron McCurry < >>> [email protected]> >>> >> > wrote: >>> >> > >> >>> >> > >>> I have created another branch to 0.2-dev, >>> 0.2-dev-thrift-changes (I >>> >> > hope >>> >> > >> to >>> >> > >>> push the broken/in-progress branch tonight) where I am >>> attempting to >>> >> > >> remove >>> >> > >>> the legacy Blur Thrift calls and clean up the code base. From >>> >> there I >>> >> > >> hope >>> >> > >>> to improve the units and separate integration tests from the >>> unit >>> >> > tests. >>> >> > >>> >>> >> > >>> Has anyone separated these types of tests in maven before? I >>> have >>> >> read >>> >> > >>> about a few ways to do it, but I looking for a sort of best >>> >> practice. >>> >> > >>> >>> >> > >>> Thanks! >>> >> > >>> >>> >> > >>> Aaron >>> >> > >>> >>> >> > >> >>> >> > >>> >> >>> > >>> > >>> >> >> >
