[ 
https://issues.apache.org/jira/browse/BLUR-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592182#comment-13592182
 ] 

Gagan Deep Juneja commented on BLUR-54:
---------------------------------------

I think that first option is fine because control is moving to 
BlurServer.getConnection() and creating instance of TableLayout. We can just 
put null check and throw exception in case shard doesn't exist. Please provide 
your inputs.

Regards,
Gagan
                
> Improve the error when a bad shard index is provided.
> -----------------------------------------------------
>
>                 Key: BLUR-54
>                 URL: https://issues.apache.org/jira/browse/BLUR-54
>             Project: Apache Blur
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Tim Williams
>            Priority: Trivial
>
> Currently, if a client passes an unknown shard index, they get a message 
> about a bad connection string when in fact that's just a side effect.  I'm 
> thinking that the TableLayout implemented in ThriftBlurServer should throw a 
> RuntimeException if it isn't found - because that's where we have some useful 
> context.  Sound reasonable?  Another option is to throw it in BlurServer's 
> getConnection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to