Yes it is the responsibility of createTable, and yeah we should just perform a hard check on the shard count. And if the table path doesn't exist we should just throw an exception.
Aaron On Sun, May 26, 2013 at 11:16 AM, Gagan Juneja <[email protected]>wrote: > Yeah But for the first time who is responsible to create the table > path and shard directories, Is it the job of createTable? Do we need > to remove the check from patch in case where we skip the shardcount > check if table doesn't exist? > > > Regards, > Gagan > > > On Sun, May 26, 2013 at 7:17 PM, Aaron McCurry (JIRA) <[email protected]> > wrote: > > > > [ > https://issues.apache.org/jira/browse/BLUR-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667325#comment-13667325] > > > > Aaron McCurry commented on BLUR-107: > > ------------------------------------ > > > > The patch looks good. Commit it! Thanks! > > > > Aaron > > > >> Create checkOutputSpecs check in the BlurOutputFormat > >> ----------------------------------------------------- > >> > >> Key: BLUR-107 > >> URL: https://issues.apache.org/jira/browse/BLUR-107 > >> Project: Apache Blur > >> Issue Type: Bug > >> Affects Versions: 0.1.5 > >> Reporter: Aaron McCurry > >> Fix For: 0.1.5 > >> > >> Attachments: 0001-BLUR-107-checkOutputSpecs-check.patch > >> > >> > >> Using the checkOutputSpecs method on the BlurOutputFormat validate that > the number of reducers is valid number. Also check that the Blur table > exists and that the number of shards in the FS match the table descriptor. > > > > -- > > This message is automatically generated by JIRA. > > If you think it was sent incorrectly, please contact your JIRA > administrators > > For more information on JIRA, see: > http://www.atlassian.com/software/jira >
