Hmm, I see what you saying let me take a closer look at it and report back.
Aaron On Tue, Oct 8, 2013 at 12:48 PM, saurabh gupta <[email protected]>wrote: > Hi, > > In BlurNRT class there is a code which loads the existing snapshots: > > if (snapshotsDirectoryExists()) { > // load existing snapshots > sdp = new > SnapshotDeletionPolicy(_tableContext.getIndexDeletionPolicy(), > loadExistingSnapshots()); > } else { > sdp = new > SnapshotDeletionPolicy(_tableContext.getIndexDeletionPolicy()); > } > > But now in 4.4 version there is no constructor with second argument. They > changed it corresponding to > LUCENE-4973<http://issues.apache.org/jira/browse/LUCENE-4973> > . > > Also to open a old snapshot the > > IndexCommit snapshot = snapshotter.getSnapshot(name); > > changed to > > IndexCommit snapshot = snapshotter.getIndexCommit(long gen); > > which takes generation > > I am not getting how to get the generation. > > I hope you understand what I am trying to say. > > Thanks, > Saurabh Gupta > > > On Tue, Oct 8, 2013 at 2:54 AM, Aaron McCurry <[email protected]> wrote: > > > On Mon, Oct 7, 2013 at 4:54 PM, saurabh gupta <[email protected]> > > wrote: > > > > > Hi > > > > > > I am looking an improvement BLUR-208. I am stuck at one place in > BlurNRT > > > class where we are loading previous snapshots and set in > > > SnapshotDeletionPolicy. But now there is no way to load previous > > snapshots. > > > > > > > We haven't built a way to load in previous snapshots. We have planned on > > doing so but have not actually implemented it yet. We left the snapshots > > incomplete because at the time we were trying to write an InputFormat for > > Hadoop. > > > > It shouldn't be too hard to do if the table is offline. Online moves to > > previous snapshots will be tricky. > > > > > > > > > > Also SnapshotDeletionPolicy is returning list of IndexCommit and > > otherwise > > > we have to use generation to get the specific IndexCommit. Now I dont > > know > > > how to get the generation. > > > > > > > Are you asking about how it works in Lucene or in Blur? In Blur we > create > > a snapshot label to manage the snapshots. > > > > The Lucene basic code needed to open an old snapshot would be something > > like: > > > > IndexCommit snapshot = snapshotter.getSnapshot(name); > > > > DirectoryReader.open(snapshot); > > If you could let us know what / how you would expect Blur to behave when > > loading an old snapshot that would be great. Real world use cases are > the > > best to work toward. > > > > Thanks! > > > > Aaron > > > > > > > > > Can anyone help me? > > > > > > Thanks > > > Saurabh > > > > > >
