Cool, this process works and closes out the github pull requests. We should definitely consider this for future contributions.
On Sun Oct 26 2014 at 1:47:44 PM Chris Rohr <[email protected]> wrote: > If no one minds, I would like to try this on the existing PRs. One of 3 > PRs was submitted by me through the Github UI so I can play with that one > to see if it works. > > On Sun Oct 26 2014 at 1:43:08 PM Chris Rohr <[email protected]> wrote: > >> As a follow up, today I found this link on how to handle PRs with Apache >> and Github. I think this is a great step by step plan (and shows how to >> close out PRs). >> >> https://mahout.apache.org/developers/github.html >> >> On Thu Oct 16 2014 at 10:56:27 AM Tim Williams <[email protected]> >> wrote: >> >>> I've asked around a while back about what other projects are doing - >>> most apparently have scripts to accept the pull requests. I reckon we >>> could pick the best one as our starting point and make it our own? >>> Here are some pointers: >>> >>> Apache Wicket project >>> https://github.com/martin-g/dotfiles/blob/master/bin/github-pr.sh >>> >>> Mesos >>> https://github.com/apache/mesos/blob/master/support/apply-review.sh >>> https://github.com/jfarrell/rbt-github >>> >>> Cordova >>> https://github.com/apache/cordova-coho/blob/master/docs/proc >>> essing-pull-requests.md >>> >>> >>> On Wed, Oct 15, 2014 at 4:13 PM, Chris Rohr <[email protected]> >>> wrote: >>> > Does anyone have write access to the github repo? Without it we can't >>> > accept pull requests. >>> > >>> > Thanks, >>> > Chris >>> >>
