[
https://issues.apache.org/jira/browse/BLUR-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611291#comment-14611291
]
Aaron McCurry edited comment on BLUR-347 at 7/2/15 1:20 AM:
------------------------------------------------------------
- Minor things I noticed, you might (or might not) want to change these in a
future release. Apache v2 software listed in LICENSE but not required as per
[1]. But having them listed does make reviewing easier, especially as you have
both the MIT and Apache licensed versions of bootcamp in your source
distribution. Also means you can check if Apache Thrift NOTICE has been taken
into account (it has/nothing required).
We were going for ease of checking of the licenses.
- bootstrap is MIT license is since 3.2.0 (I think), not 3 as mentioned in
LICENSE [2], 3.x has been both Apache and MIT licensed
Corrected.
https://github.com/twbs/bootstrap/tree/v3.0.0 == Apache
https://github.com/twbs/bootstrap/tree/v3.2.0 == MIT
- There's some empty files in distribution/src/main/resources-hadoop1/notices/
I assume that because the bundled software in question doesn't have a NOTICE
file?
Yes they were missing NOTICE files.
- year in NOTICE is incorrect (2013 not 2014)
Corrected to 2015
- one or two text files don't have Apache headers (eg
distribution/src/main/scripts/conf/default_zoo.cfg)
I have added headers to those files and removed the exclude clauses from the
main pom rat config.
was (Author: amccurry):
- Minor things I noticed, you might (or might not) want to change these in a
future release. Apache v2 software listed in LICENSE but not required as per
[1]. But having them listed does make reviewing easier, especially as you have
both the MIT and Apache licensed versions of bootcamp in your source
distribution. Also means you can check if Apache Thrift NOTICE has been taken
into account (it has/nothing required).
We were going for ease of checking of the licenses.
- bootstrap is MIT license is since 3.2.0 (I think), not 3 as mentioned in
LICENSE [2], 3.x has been both Apache and MIT licensed
https://github.com/twbs/bootstrap/tree/v3.0.0 == Apache
https://github.com/twbs/bootstrap/tree/v3.2.0 == MIT
- There's some empty files in distribution/src/main/resources-hadoop1/notices/
I assume that because the bundled software in question doesn't have a NOTICE
file?
Yes they were missing NOTICE files.
- year in NOTICE is incorrect (2013 not 2014)
Corrected to 2015
- one or two text files don't have Apache headers (eg
distribution/src/main/scripts/conf/default_zoo.cfg)
I have added headers to those files and removed the exclude clauses from the
main pom rat config.
> Cleanup of LICENSE and NOTICE files per IPMC feedback
> -----------------------------------------------------
>
> Key: BLUR-347
> URL: https://issues.apache.org/jira/browse/BLUR-347
> Project: Apache Blur
> Issue Type: Bug
> Components: Blur
> Affects Versions: 0.2.4
> Reporter: Tim Williams
> Fix For: 0.2.4
>
>
> With the latest release vote Justin gave us some good feedback that should
> get resolved:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201407.mbox/%3C8F4C08C0-8B1F-4388-A308-95D4BAEE862E%40classsoftware.com%3E
> Minor things I noticed, you might (or might not) want to change these in a
> future release.
> - Apache v2 software listed in LICENSE but not required as per [1]. But
> having them listed
> does make reviewing easier, especially as you have both the MIT and Apache
> licensed versions
> of bootcamp in your source distribution. Also means you can check if Apache
> Thrift NOTICE
> has been taken into account (it has/nothing required).
> - bootstrap is MIT license is since 3.2.0 (I think), not 3 as mentioned in
> LICENSE [2], 3.x
> has been both Apache and MIT licensed
> - There's some empty files in
> distribution/src/main/resources-hadoop1/notices/ I assume that
> because the bundled software in question doesn't have a NOTICE file?
> - year in NOTICE is incorrect (2013 not 2014)
> - one or two text files don't have Apache headers (eg
> distribution/src/main/scripts/conf/default_zoo.cfg)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
