On 01/11/2013 07:55 PM, Gianfranco Costamagna wrote: > Gentoo's ebuild sstem is still complaining about this : > > QA: other > QA Notice: Package triggers severe warnings which indicate that it > may exhibit random runtime failures. > ./zip/z_fileio.c:310:7: warning: implicit declaration of function > 'dosmatch' [-Wimplicit-function-declaration] > ./zip/unix/z_unix.c:127:7: warning: implicit declaration of function > 'dosmatch' [-Wimplicit-function-declaration] > Please do not file a Gentoo bug and instead report the above QA > issues directly to the upstream developers of this software. > Homepage: http://boinc.ssl.berkeley.edu/ > > Hi Toralf, zip seems to be mantained here [1] [2]. > > upstream is not berkeley, so I might suggest to try the latest 3.0 > version (if it complains anymore), and for upstream folks to update it :) > > [1] ftp://ftp.info-zip.org/pub/infozip/src/ > [2] http://www.info-zip.org > > Gianfranco
Hello, upstream answered : http://www.info-zip.org/phpBB3/viewtopic.php?f=6&t=407&e=0 I'm copying that content here : > ./zip/z_fileio.c:310:7: warning: implicit declaration of function > 'dosmatch' [-Wimplicit-function-declaration] > ./zip/unix/z_unix.c:127:7: warning: implicit declaration of function > 'dosmatch' Those "z_" prefixes on the file names are not ours, so I'll assume that they were added by someone to avoid collisions. Apparently, some other changes were also made to our code. Our "unix/unix.c" modules do not use dosmatch(), so we never see this compiler complaint. In the current code (and probably in older versions), dosmatch() is declared in "zip.h", but it's conditional on things like: # if defined(DOS) || defined(WIN32) because that's where we use it. If someone has changed our (dosmatch()-free) "fileio.c" or "unix/unix.c" to use dosmatch(), then he should have changed the condition(s) on the prototype/declaration in "zip.h", too. > [...] report the above QA issues directly to the upstream developers > of this software. If you break it, it's yours. If there are some harmless changes which we could make in our code to make it easier to use in some other application, then we'd be happy to consider adding them, but we're probably not willing to rename all the source files, and someone would need to figure out what those changes really are. For example, adding a C macro like "DECLARE_DOSMATCH" to "zip.h" might be reasonable, if it would be helpful. But it might be wise to find all the changes which were made to the Info-ZIP code before trying to decide what should have been done instead. > [...] wondering whether those issues are fixed in versino 3.0 Probably not, but any such problems seem to be yours, not ours. If you believe otherwise, we're always open to a good argument (with actual evidence). -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 _______________________________________________ boinc_dev mailing list [email protected] http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
