On every platform (except possibly windows), every file source should include config.h. If it doesn't the proper fix is include config.h, not to modify things so it works without config.h.
On Mon, Feb 4, 2013 at 8:29 AM, Rom Walton <[email protected]> wrote: > The previous patch as applied broke on Windows and Linux. > > Windows because config.h is empty and therefore HAVE_XLOCALE_H is never > defined, and on Linux because AsyncRPC.cpp didn't include config.h IIRC. > > What I would like to do is: > > 1. Move the code for Windows outside the NO_PER_THREAD_LOCALE checks. > 2. Move the struct SET_LOCALE declaration and implementation out of > gui_rpc_client.h and into gui_rpc_client_ops.cpp. > 3. Tweak things so we can remove the NO_PER_THREAD_LOCALE symbol > altogether and replace it with configure.ac symbols and let the autoconf > environment figure out if the functionality exists on the platform being > compiled for. Tweak the Mac config.h file accordingly. > > Problem is getting a new public release put together is taking a little > longer than originally planned and this change is a little too risky to do > right now. > > ----- Rom > > -----Original Message----- > From: [email protected] [mailto: > [email protected]] On Behalf Of Maxime Villard > Sent: Monday, February 04, 2013 11:01 AM > To: Charlie Fenton > Cc: [email protected] > Subject: Re: [boinc_dev] [PATCH] OpenBSD support > > Le 03/02/2013 01:08, Charlie Fenton a écrit : > > As Rom wrote, I fixed the Mac issue by manually adding HAVE_XLOCALE_H to > mac_build/config.h, because neither the Mac builds nor the Windows builds > use configure / make. > > > > I noticed that Rom later removed the references to HAVE_XLOCALE_H, which > puzzled me. This is the first I have heard of anything else. I now see > below that Rom wrote: > >>>> >>>I was just pressed for time on getting the next build out, so I > >>>> >>>just reverted it until we could properly address it. > > Regarding this: > >>> >>We should ask Charlie if he can put the define somewhere else... > > Rom, which define are you talking about? This is the first I have heard > about any of this. > > > > Cheers, > > --Charlie > > The only question is: does my previous patch break something on other > systems? > _______________________________________________ > boinc_dev mailing list > [email protected] > http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev > To unsubscribe, visit the above URL and > (near bottom of page) enter your email address. > _______________________________________________ > boinc_dev mailing list > [email protected] > http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev > To unsubscribe, visit the above URL and > (near bottom of page) enter your email address. > > _______________________________________________ boinc_dev mailing list [email protected] http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
