----- Messaggio originale -----
> Da: Alyssa Milburn <[email protected]>
> A: Gianfranco Costamagna <[email protected]>
> Cc: "[email protected]" <[email protected]>;
> "[email protected]" <[email protected]>
> Inviato: Martedì 9 Luglio 2013 18:38
> Oggetto: Re: [boinc_dev] addressing some clang warnings
>
> On Tue, Jul 09, 2013 at 02:46:31PM +0100, Gianfranco Costamagna wrote:
>> I changed the debian patch based on your suggestions and committed
>>
> http://anonscm.debian.org/gitweb/?p=pkg-boinc/boinc.git;a=commitdiff;h=2b58a04fa4290ef57ea8b06cfc3c353182ad1f26
>
> The fscanf(f, ".") returns 0 on success (since it matches nothing), so
> that is still wrong, I guess? Complicated!
>
> The '1 == fr' doesn't make much sense to me .. I guess it would be
> best
> as '4096 != fr' (if I understand the items correctly)?
>
committed
http://anonscm.debian.org/gitweb/?p=pkg-boinc/boinc.git;a=commitdiff;h=7060e191063982342bd8194a19d327f6ea32f040
and
http://anonscm.debian.org/gitweb/?p=pkg-boinc/boinc.git;a=commitdiff;h=60f2057c4c7e1b5d98b29e190c5aa1098a51cbcf
I hope now is ok :)
bests and thanks
Gianfranco
I prefer to check if fr < 4096 instead of != 4096
>> is everything ok now?
>> (write should return -1 in case of failure AFAICS)
>
> I guess if you want to be *perfect* then you could check whether write
> wrote exactly the right amount (so, 1, in the bit at the end of the
> patch)? But it's already over-the-top to check all this maybe. :)
>
> - Alyssa
>
_______________________________________________
boinc_dev mailing list
[email protected]
http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev
To unsubscribe, visit the above URL and
(near bottom of page) enter your email address.
