[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093633#comment-13093633
 ] 

Ivan Kelly commented on BOOKKEEPER-57:
--------------------------------------

Why not just check if the bookie.zk is null rather than adding another boolean 
flag? 

This would be better as there are cases where zk is never changed from null 
(testing cases, where zk isn't used and we communicate directly with the 
bookie). 

Also, Im not sure what you mean by recovery in this context. This is startup 
code. 

> NullPointException at bookie.zk@EntryLogger
> -------------------------------------------
>
>                 Key: BOOKKEEPER-57
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-57
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 3.4.0
>            Reporter: xulei
>             Fix For: 3.4.0
>
>         Attachments: bookkeeper-57.patch
>
>
> In Bookie.java, if the recovery time is longer than gcWaitTime, bookie.zk is 
> null and gc thread will exit

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to