[
https://issues.apache.org/jira/browse/BOOKKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095844#comment-13095844
]
Ivan Kelly commented on BOOKKEEPER-60:
--------------------------------------
Done. Still not sure how to do it though. Usually you deprecate for 1 release
and then remove in the next. However, in this case, deprecation isn't an option.
> confusion between multiple "consume" methods
> --------------------------------------------
>
> Key: BOOKKEEPER-60
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-60
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-client
> Reporter: Matthieu Morel
> Priority: Minor
> Fix For: 4.0.0
>
>
> There are currently 2 methods named "consume" in the client API:
> - in org.apache.hedwig.client.api.MessageHandler : delegates the processing
> of a message by a message handler
> - in org.apache.hedwig.client.api.Subscriber : notifies the server that
> messages have been processed till a given sequence id. This is some kind of
> acknowledgement.
> I don't think these 2 fundamental methods should be named the same: they have
> different purposes and it is confusing.
> Couldn't we rename Subscriber.consume into Subscriber.acknowledge, or
> something similar?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
