> On 2011-10-10 09:20:36, Ivan Kelly wrote: > > /bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java, > > line 208 > > <https://reviews.apache.org/r/2313/diff/1/?file=48979#file48979line208> > > > > Should throw an Exception instead of returning an error code.
Crap, Adding an exception would be a compatibility break at the source level. Changing the return type is a break at the binary level. Perhaps we should have an API review before 3.4.0 release and fix the things in the APIs all at once before the "initial" release. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2313/#review2474 ----------------------------------------------------------- On 2011-10-08 13:03:41, fpj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2313/ > ----------------------------------------------------------- > > (Updated 2011-10-08 13:03:41) > > > Review request for bookkeeper and Ivan Kelly. > > > Summary > ------- > > Patch for BookKeeper-68. > > > Diffs > ----- > > > /bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java > 1172822 > > /bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java > 1172822 > > /bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java > 1172822 > > /bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java > 1172822 > > /bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConditionalSetTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2313/diff > > > Testing > ------- > > > Thanks, > > fpj > >
