[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128890#comment-13128890
 ] 

[email protected] commented on BOOKKEEPER-83:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2401/
-----------------------------------------------------------

Review request for bookkeeper, fpj and Benjamin Reed.


Summary
-------

There is no concept of versions in the BookKeeper protocol at the moment. This 
patch addresses that. 


This addresses bug BOOKKEEPER-83.
    https://issues.apache.org/jira/browse/BOOKKEEPER-83


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 
eb76a1d 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java 
63084a8 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java 
1ff135b 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
 b38604a 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 9141067 
  
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestProtoVersions.java
 PRE-CREATION 
  
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
 4cfaf30 

Diff: https://reviews.apache.org/r/2401/diff


Testing
-------


Thanks,

Ivan


                
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-83
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. 
> This patch addresses that. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to