[
https://issues.apache.org/jira/browse/BOOKKEEPER-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135844#comment-13135844
]
Ivan Kelly commented on BOOKKEEPER-93:
--------------------------------------
I see you created BOOKKEEPER-94 for the test change. That change should
actually be part of this JIRA. It's part 1) (The two callback changes) which
should be in the other JIRA, as it's unrelated, whereas 2) & 3) and the fix to
testing is all the same thing.
Regarding 2 & 3, these changes look good. However, I'd change the unsafeRead
flag to be called readOnly. Also, add a logging line before the addComplete in
asyncAddEntry saying that the client tried to write on a read only ledger
handle.
> bookkeeper doesn't work correctly on OpenLedgerNoRecovery
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-93
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-93
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 3.4.0
>
> Attachments: bookkeeper-93.patch, bookkeeper-93_v2.patch
>
>
> 1) bookkeeper hang when openLedgerNoRecovery, since LedgerOpenOp didn't
> trigger callback when opening ledger no recovery.
> 2) race condition in ReadLastConfirmOp
> ReadLastConfirmOp callback on readEntryComplete.
> a) first decrement numResponsePending
> b) then increment validResponses
> c) check validResponses to callback with OK
> b) check numResponsePending to callback with LedgerRecoveryException
> support two callbacks returns on readEntryComplete: A, B. (quorum/ensemble
> size : 2)
> a) A first decrement numResponsePending from 2 to 1.
> b) A increment validResponses from 0 to 1.
> c) B then decrement numResponsePending from 1 to 0.
> d) A check numResponsePending before B check validResponse, A found the
> numResponsePending is 0 now. A will callback with exception. But the right
> action is B check validResponse and callback with OK.
> 3) if an LegerHandle is opened by openLedgerNoRecovery, the lastAddConfirmed
> will be set to -1. so all read requests will be failed since readEntry id >
> lastAddConfirmed.
> so I suggested that if an LegerHandle is opened by openLegerNoRecovery, the
> ledgerHandle is under unsafeRead mode. close/write operations will be failed,
> read operations should not check condition entry_id > lastAddConfirmed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
