[
https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136010#comment-13136010
]
Benjamin Reed commented on BOOKKEEPER-89:
-----------------------------------------
looks great. i like how you moved the callbacks from the class to inner
classes! my one comment is that i think we should keep the accessor for the
ZooKeeper public. if you are using bookkeeper and you want to do some zookeeper
operations, usually you want to use the same zookeeper object to keep any
session events in sync.
> Bookkeeper API changes for initial Bookkeeper release
> -----------------------------------------------------
>
> Key: BOOKKEEPER-89
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-89.diff, BOOKKEEPER-89.diff,
> BOOKKEEPER-89.diff, BOOKKEEPER-89.diff, BOOKKEEPER-89.diff,
> TEST-org.apache.bookkeeper.test.BookieReadWriteTest.xml
>
>
> Changes are as follows.
> BookKeeper#createLedger, parameter is named passwd, "Key" used in
> LedgerHandle api
> BookKeeper#getBookieClient shouldn't be public
> BookKeeper#createComplete shouldn't be public
> BookKeeper#openComplete shouldn't be public
> BookKeeper#deleteComplete shouldn't be public
> BookKeeper#halt could be changed to close(), should throw a BKException
> LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be
> private
> LedgerHandle#getLedgerMetadata shouldn't be public
> LedgerHandle#getDigestManager shouldn't be public
> LedgerHandle#getDistributionSchedule shouldn't be public
> LedgerHandle#writeLedgerConfig shouldn't be public
> LedgerHandle#addEntry should return void, errors should go in an Exception
> LedgerHandle#readComplete should not be public
> LedgerHandle#addComplete should not be public
> LedgerHandle#readLastConfirmedCompelte should not be public
> LedgerHandle#closeComplete should not be public
> ASyncCallback#RecoverCallback shouldn't be public
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
