-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2570/
-----------------------------------------------------------
(Updated 2011-10-28 11:59:22.626468)
Review request for bookkeeper.
Changes
-------
made changed according to Ivan's suggestions:
1) move it to hedwig-server, so the console can be distributed with
hedwig-server, which ease administration.
2) move commands and options to a separated file, change them to final static
strings.
3) can use 'help <command>' to display detail usage for a specific command
4) change zkquorum to zkserver
since, 'describe topic <topic>' can display subscriptions of a specific topic,
so I didn't add a new command for 'show subscriptions'.
Summary
-------
using zookeeper client to read metadata, use hedwig client to interact with
hedwig, use bookkeeper client to openLedgerNoRecovery to read messages to
implement a hedwig console
This addresses bug BOOKKEEPER-77.
http://issues.apache.org/jira/browse/BOOKKEEPER-77
Diffs (updated)
-----
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/bin/hedwig
1188996
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/pom.xml
1188996
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java
PRE-CREATION
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
PRE-CREATION
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/JLineHedwigCompletor.java
PRE-CREATION
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2570/diff
Testing
-------
Thanks,
Sijie
