[ https://issues.apache.org/jira/browse/BOOKKEEPER-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139389#comment-13139389 ]
jirapos...@reviews.apache.org commented on BOOKKEEPER-69: --------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2615/ ----------------------------------------------------------- Review request for bookkeeper. Summary ------- implement the proposal to fix race condition of topic manager This addresses bug BOOKKEEPER-69. http://issues.apache.org/jira/browse/BOOKKEEPER-69 Diffs ----- http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicStatus.java PRE-CREATION http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/TrivialOwnAllTopicManager.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/topics/StubTopicManager.java 1194964 http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestConcurrentTopicAcquisition.java PRE-CREATION http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java 1194964 Diff: https://reviews.apache.org/r/2615/diff Testing ------- Thanks, Sijie > ServerRedirectLoopException when a machine (hosts bookie server & hub server) > reboot, which is caused by race condition of topic manager > ---------------------------------------------------------------------------------------------------------------------------------------- > > Key: BOOKKEEPER-69 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-69 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-client, hedwig-server > Affects Versions: 3.4.0 > Environment: 3 machines (perf8, perf9, perf10), each machine hosts a > bookie server & a hub server. > perf8 is used as default server for client 1. perf9 is used as default server > for client 2. > bookkeeper is configured as below: > ensemble size is 3, quorum size is 2. > Reporter: Sijie Guo > Priority: Critical > Attachments: bookkeeper-69-testcase.patch, bookkeeper-69.patch > > > 1) machine perf10 is rebooted. the bookie server & hub server are not > restarted automatically after reboot. > 2) client 1 & client 2 are still running. the topics owned in perf10 will be > re-assigned to perf8/perf9. but they would fail because not enough bookie > servers are available. > 3) after 2 hours, we found that perf10 is rebooted. we restarted bookie > server & hub server on perf10 > 4) then we got ServerRedirectLoopException in client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira