[
https://issues.apache.org/jira/browse/BOOKKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147553#comment-13147553
]
[email protected] commented on BOOKKEEPER-82:
---------------------------------------------------------
bq. On 2011-11-09 17:48:34, fpj wrote:
bq. > Good job, Sijie. I only have a few minor comments. One important general
comment I have is that we need documentation for this feature. Ideally we
commit a patch for BOOKKEEPER-82 that includes doc changes. Otherwise, I'd like
to have a blocker jira to make sure that we don't have a release without the
doc changes.
I would add doc for this feature.
bq. On 2011-11-09 17:48:34, fpj wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java,
line 592
bq. > <https://reviews.apache.org/r/2745/diff/1/?file=56625#file56625line592>
bq. >
bq. > I think we can remove this todo, right?
Yes.
bq. On 2011-11-09 17:48:34, fpj wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java,
line 598
bq. > <https://reviews.apache.org/r/2745/diff/1/?file=56625#file56625line598>
bq. >
bq. > Typo on journal.
I will fix it.
bq. On 2011-11-09 17:48:34, fpj wrote:
bq. >
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java,
line 460
bq. > <https://reviews.apache.org/r/2745/diff/1/?file=56626#file56626line460>
bq. >
bq. > If there are corrupted entries, it is true that we can fetch copies
from other bookies, but I don't think we have a mechanism for doing it yet, so
it sounds safer to keep throwing an exception here for now, no?
I changed throwing an exception to skipping it, because I found bookie servers
can't be started due to entry logger corruption after restartBookieServers in
test cases.
This corruption is because that entry logger uses a BufferedChannel but it
doesn't do flush when shutting down. So we read partial entry after those
servers are restarted.
I will add code in EntryLogger#shutdown to ensure buffered data persisted to
disk, so it can pass unit tests.
Since corruption is a complex issue, I agreed keeping throwing an exception
here for now.
I created a jira BOOKKEEPER-62 before. Maybe we can handle data corruption in
that jira.
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2745/#review3130
-----------------------------------------------------------
On 2011-11-07 17:46:11, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2745/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-07 17:46:11)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. implement journal rolling
bq.
bq. 1) remove journals whose id are less than marked journal id. since they
journals' data and index has been persisted to disk.
bq. 2) replay entires started from marked position in marked journal to speed
up bookie start up.
bq.
bq.
bq. This addresses bug BOOKKEEPER-82.
bq. http://issues.apache.org/jira/browse/BOOKKEEPER-82
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
1198776
bq.
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
1198776
bq.
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2745/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> support journal rolling
> -----------------------
>
> Key: BOOKKEEPER-82
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-82
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: bookkeeper-82.patch, bookkeeper-82.patch_v2
>
>
> now bookkeeper is writing a single journal file, so the journal file has no
> chance to be garbage collected and the disk space keeps growing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
