----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2797/#review3178 -----------------------------------------------------------
it looks good to me. - Sijie On 2011-11-10 16:39:04, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2797/ > ----------------------------------------------------------- > > (Updated 2011-11-10 16:39:04) > > > Review request for bookkeeper. > > > Summary > ------- > > There is currently no concept of layout version between the filesystem layout > and bookie server. This could lead to potential corruption if a newer version > of the bookie server is used with an old filesystem layout. > > > This addresses bug BOOKKEEPER-104. > https://issues.apache.org/jira/browse/BOOKKEEPER-104 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > d651894 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieLayoutVersionTest.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java > 6bac569 > > Diff: https://reviews.apache.org/r/2797/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
