[
https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151326#comment-13151326
]
[email protected] commented on BOOKKEEPER-91:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2808/
-----------------------------------------------------------
(Updated 2011-11-16 16:55:05.131518)
Review request for bookkeeper.
Changes
-------
rebased to trunk@1202758
Summary
-------
Using log4j directly requires that any application using bookkeeper or hedwig
clients have to configure log4j.
We should use something like commons logging[1] or slf4j[2].
[1] http://commons.apache.org/logging/index.html
[2] http://www.slf4j.org/
This addresses bug BOOKKEEPER-91.
https://issues.apache.org/jira/browse/BOOKKEEPER-91
Diffs (updated)
-----
bookkeeper-benchmark/pom.xml 3f905ae
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/MySqlClient.java
ad5f445
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/TestClient.java
213763f
bookkeeper-server/pom.xml fd6cef6
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
6140ee0
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
1fafac1
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
7c4f250
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
1aa3594
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
037c018
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
36c3bd1
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
883ccff
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java
b2fbc6b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java
97552e6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
56b7a8c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java
97b06fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java
8f65e1b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
9e0e95a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
30584bf
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
037e2e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
5a898d9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
bbe7986
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
baa7209
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
c78bcf6
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
d7b25c5
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
7876eb4
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
5395acf
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
8d060cb
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java
911b539
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java
bbde2fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java
e15f0a4
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
4e5b134
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/SafeRunnable.java
b8284b8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java
39334af
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
1d498ee
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java
07639aa
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java
6614bc5
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
728c35d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
581f3ad
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
8dbae67
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java
74b5d6f
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/CloseTest.java
b43db91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConcurrentLedgerTest.java
ebb17d2
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConditionalSetTest.java
0b04a91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java
48d5e70
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerRecoveryTest.java
50cbfa9
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java
c12c041
hedwig-client/pom.xml bab780a
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java
0e87dd7
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java
79acc96
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/HedwigBenchmark.java
643f6d9
hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java
52e5704
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java
2e11d63
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PubSubCallback.java
563ad65
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PublishResponseHandler.java
90e62ba
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeReconnectCallback.java
60388fa
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
2256a68
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/UnsubscribeResponseHandler.java
f12e476
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java
3f13754
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClient.java
b270d34
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
e381107
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
7b21a4d
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ResponseHandler.java
378bb19
hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java
a8cac77
hedwig-client/src/main/java/org/apache/hedwig/util/CallbackUtils.java c90e0e6
hedwig-client/src/main/java/org/apache/hedwig/util/FileUtils.java 98e41e1
hedwig-server/pom.xml b6d2e65
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/AbstractBenchmark.java
cd2d65e
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookieBenchmark.java
ff1462d
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java
b3229a1
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/FakeBookie.java
a394d05
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java
419b9b0
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
af3d12e
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java
2f510c8
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
cf56c73
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java
5196a44
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
a6079df
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/CacheValue.java
ef42009
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
84ebd62
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
31e9c06
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java
f8b836a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConsumeHandler.java
8bbd68a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStartDeliveryHandler.java
07706c1
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStopDeliveryHandler.java
6f5eb20
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxySubscribeHandler.java
8112a5c
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java
9533d8c
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
bf320dd
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java
b480fa0
hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java
05562c9
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java
e884d76
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java 8f0de63
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java
125cd93
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java
d320c6b
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java
1e3d5dd
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java
3ed363e
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java
3a079f2
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java
e89dd4c
hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java
31b1dc1
Diff: https://reviews.apache.org/r/2808/diff
Testing
-------
Thanks,
Ivan
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff, BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig
> clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
