[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152804#comment-13152804
 ] 

Ivan Kelly commented on BOOKKEEPER-79:
--------------------------------------

I think your patch is good. Could you rename last_response to 
outstanding_response? Also, the full test suite doesn't succeed when I run this 
on trunk. One problem is BOOKKEEPER-115, but once that is fixed, there are 
still problems. (running with make check)

The thread issue is something we should look at in general in the future. Im of 
the opinion that we should only have one one channel per hub. But that requires 
server side buffering of messages. 

{quote}
Beside the number of threads issue, #stopReceiving will be blocked if no data 
sent from server in the channel, since it only be notified in 
messageCallbackHandler. async_read will not trigger the bound callback if no 
data read from the channel.
{quote}
This was where I got stuck yesterday before giving up.



                
> randomly startDelivery/stopDelivery will core dump in c++ hedwig client
> -----------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-79
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-79
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: hedwig-client
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.0.0
>
>         Attachments: BOOKKEEPER-79.patch_v2, BOOKKEEPER-79.patch_v3, 
> bookkeeper-79.patch, pubsubtest.cpp
>
>
> in our test program, we tried to startDelivery/stopDelivery different 
> subscriptions randomly. And it core dump.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to