[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152921#comment-13152921
 ] 

Sijie Guo commented on BOOKKEEPER-114:
--------------------------------------

since Entry log files use BufferedChannel, a non-clean shutdown will corrupt 
them, as comments in 
[BOOKKEEPER-82|https://issues.apache.org/jira/browse/BOOKKEEPER-82?focusedCommentId=13147692&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13147692]
 . And we also add some documents in BOOKKEEPER-109 describing data flush 
during shutting down.

And bookie server can't start when encountering corrupted entries, as described 
in BOOKKEEPER-62 .

I think for now it is better to avoid such corruption first, since we don't 
have a clear solution in BOOKKEEPER-62 .
                
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
>                 Key: BOOKKEEPER-114
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
>             Project: Bookkeeper
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.0.0
>
>         Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, 
> kill pid, the data buffered in BufferedChannel has no chanced to be flushed, 
> which may make files corrupted. 
> We should add a shutdown hook to shut down bookie server safely, which will 
> be called when JVM is terminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to