[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155808#comment-13155808
 ] 

Sijie Guo commented on BOOKKEEPER-118:
--------------------------------------

in hedwig java client, we did close old subscription channels in 
SubscribeResponseHandler when it is not a SUCCESS response.

{code}
    // Main method to handle Subscribe responses from the server that we sent
    // a Subscribe Request to.
    public void handleSubscribeResponse(PubSubResponse response, PubSubData 
pubSubData, Channel channel)
            throws Exception {
        // If this was not a successful response to the Subscribe request, we
        // won't be using the Netty Channel created so just close it.
        if (!response.getStatusCode().equals(StatusCode.SUCCESS)) {
            
HedwigClientImpl.getResponseHandlerFromChannel(channel).channelClosedExplicitly 
= true;
            channel.close();
        }
        ...
    }
{code}

this issue just happens in hedwig cpp client.
                
> Hedwig client doesn't kill and remove old subscription channel after 
> redirection.
> ---------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-118
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: hedwig-client
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>         Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old 
> subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to