[
https://issues.apache.org/jira/browse/BOOKKEEPER-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158533#comment-13158533
]
Benjamin Reed commented on BOOKKEEPER-53:
-----------------------------------------
+1 looks good. i think this is the correct way to do it.
> race condition of outstandingMsgSet@SubscribeResponseHandler
> --------------------------------------------------------------
>
> Key: BOOKKEEPER-53
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-53
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: xulei
> Assignee: Flavio Junqueira
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-53.patch
>
>
> outstandingMsgSet is a Set, so it is not thread-safe. The detail is as below:
> MessageConsumeRetryTask is In a timer, so in timer thread, when the timer is
> up, it will cause a outstandingMsgSet add operation:
> MessageConsumeRetryTask.run() -> outstandingMsgSet.add(message) ->
> outstandingMsgSet.add(message)
> At the same time, in other thread(maybe main thread), there may be other
> operations of this outstandingMsgSet:
> MessageConsumeCallback.operationFinished() -> messageConsumed(Message
> message) -> outstandingMsgSet.remove(message);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
