[
https://issues.apache.org/jira/browse/BOOKKEEPER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174654#comment-13174654
]
[email protected] commented on BOOKKEEPER-133:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3293/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Currently hub server use counter-based mechanism to update subscription state
lazily to zookeeper.
But in the following case, it didn't do it.
1) losing ownership of Topic
2) hub server shuts down
This addresses bug BOOKKEEPER-133.
https://issues.apache.org/jira/browse/BOOKKEEPER-133
Diffs
-----
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java
f4db619
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
8c2d77f
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
78d1435
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionState.java
8ee92e3
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/SubscriptionManager.java
d40a029
hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java
0c3c4df
hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java
6e4b2c9
hedwig-server/src/main/java/org/apache/hedwig/server/topics/TrivialOwnAllTopicManager.java
1f6654f
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java
b1bd9a4
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java
8f77a1b
hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java
3782e82
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/StubPersistenceManager.java
84b866d
hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestUpdateSubscriptionState.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3293/diff
Testing
-------
Thanks,
Sijie
> Hub server should update subscription state to zookeeper when losing topic or
> shutting down
> -------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-133
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-133
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-133.patch
>
>
> Currently hub server use counter-based mechanism to update subscription state
> lazily to zookeeper.
> But in the following case, it didn't do it.
> 1) losing ownership of Topic
> 2) hub server shuts down
> 3) a subscription channel disconnected
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
