-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3472/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Bookie recovery updates the ledger metadata in zookeeper. LedgerHandle will not
get notified of this update, so it will try to write out its own ledger
metadata, only to fail with KeeperException.BadVersion. This effectively fences
all write operations on the LedgerHandle (close and addEntry). close will fail
for obvious reasons. addEntry will fail once it gets to the failed bookie in
the schedule, tries to write, fails, selects a new bookie and tries to update
ledger metadata.
Update Line 605, testSyncBookieRecoveryToRandomBookiesCheckForDupes(), when done
Also, uncomment addEntry in
TestFencing#testFencingInteractionWithBookieRecovery()
This addresses bug BOOKKEEPER-112.
https://issues.apache.org/jira/browse/BOOKKEEPER-112
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
37623dc
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
8de20c9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
c353e46
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
80e46b9
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
e1e8449
Diff: https://reviews.apache.org/r/3472/diff
Testing
-------
Thanks,
Sijie
