[
https://issues.apache.org/jira/browse/BOOKKEEPER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187814#comment-13187814
]
[email protected] commented on BOOKKEEPER-98:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3452/#review4425
-----------------------------------------------------------
In general the code looks good. One issue with it though, is that it doesn't
allow for JMX to be enabled one multiple bookies running in a single process.
So observe this, run:
bookkeeper-server/bin/bookkeeper localbookie 3
and then run jconsole. You would expect 3 hierarchies for bookkeeper but there
is only one. This would be easily resolved by appending the port to the name in
the BookieServerBean.
- Ivan
On 2012-01-11 01:04:36, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3452/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-11 01:04:36)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. collect add/read statistics on bookie server
bq.
bq.
bq. This addresses bug BOOKKEEPER-98.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-98
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
beab5e8
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BKStats.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
12cdcec
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheMXBean.java
PRE-CREATION
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
cb3bb26
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
d2f959b
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerMXBean.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
2a8df38
bq.
bq. Diff: https://reviews.apache.org/r/3452/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> collect add/read statistics on bookie server
> --------------------------------------------
>
> Key: BOOKKEEPER-98
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-98
> Project: Bookkeeper
> Issue Type: Sub-task
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-98.patch, BOOKKEEPER-98.patch
>
>
> collect add/read statistics on bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
