> On 2012-01-17 17:19:58, Ivan Kelly wrote: > > In general the code looks good. One issue with it though, is that it > > doesn't allow for JMX to be enabled one multiple bookies running in a > > single process. So observe this, run: > > > > bookkeeper-server/bin/bookkeeper localbookie 3 > > > > and then run jconsole. You would expect 3 hierarchies for bookkeeper but > > there is only one. This would be easily resolved by appending the port to > > the name in the BookieServerBean. > >
yes. I will try to append port to the name of BookieServerBean. - Sijie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3452/#review4425 ----------------------------------------------------------- On 2012-01-11 01:04:36, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3452/ > ----------------------------------------------------------- > > (Updated 2012-01-11 01:04:36) > > > Review request for bookkeeper. > > > Summary > ------- > > collect add/read statistics on bookie server > > > This addresses bug BOOKKEEPER-98. > https://issues.apache.org/jira/browse/BOOKKEEPER-98 > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java > beab5e8 > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BKStats.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java > 12cdcec > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheMXBean.java > PRE-CREATION > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > cb3bb26 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java > d2f959b > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerBean.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServerMXBean.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java > 2a8df38 > > Diff: https://reviews.apache.org/r/3452/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
