[
https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196893#comment-13196893
]
[email protected] commented on BOOKKEEPER-23:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3662/#review4700
-----------------------------------------------------------
it looks good to me. thanks Ivan, this feature is very useful.
- Sijie
On 2012-01-27 17:39:58, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3662/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-27 17:39:58)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a client remains connected to a bookie, requests do not timeout. This
is an undesirable behavior if a bookie is up but not responding to a request
for some reason, like it is slow or has not handled an exception appropriately
and did not respond to the client. I propose to add a timeout mechanism.
bq.
bq.
bq. This addresses bug BOOKKEEPER-23.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-23
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
cb3bb26
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
5e1c964
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
2a8df38
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
2fa79bb
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadTimeout.java
PRE-CREATION
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
7403604
bq.
bq. Diff: https://reviews.apache.org/r/3662/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Timeout requests
> ----------------
>
> Key: BOOKKEEPER-23
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is
> an undesirable behavior if a bookie is up but not responding to a request for
> some reason, like it is slow or has not handled an exception appropriately
> and did not respond to the client. I propose to add a timeout mechanism.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
