----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3696/#review4711 -----------------------------------------------------------
This patch seems to enables us to increase the number of threads, but it doesn't actually increase it or allow an application to increase it through configuration. Is this intentional? bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java <https://reviews.apache.org/r/3696/#comment10436> Why do we need this synchronized block? Could you add a comment, please? bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java <https://reviews.apache.org/r/3696/#comment10434> Why do we need this synchronized block? Could you add a comment, please? - fpj On 2012-01-30 15:53:51, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3696/ > ----------------------------------------------------------- > > (Updated 2012-01-30 15:53:51) > > > Review request for bookkeeper. > > > Summary > ------- > > When benchmarking with packets smaller than 1k, performance will degrade when > the ensemble contains more than 3 bookies. See attached diagram. > > > This addresses bug BOOKKEEPER-157. > https://issues.apache.org/jira/browse/BOOKKEEPER-157 > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/CRC32DigestManager.java > fb7c8bc > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java > 547e240 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MacDigestManager.java > a3ed9f3 > > Diff: https://reviews.apache.org/r/3696/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
