[
https://issues.apache.org/jira/browse/BOOKKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198462#comment-13198462
]
[email protected] commented on BOOKKEEPER-112:
----------------------------------------------------------
bq. On 2012-02-01 15:01:34, Ivan Kelly wrote:
bq. > I had a quick look over this. The exclude bookies stuff needs to be
removed since BOOKKEEPER-23 gets rid of the need for it & it exposes internal
details through the public api which is bad. The other fix in here looks ok,
but I found it hard to pick it out with the excludeBookies stuff in there also.
if the failed bookie existed in the quorum set which maxAddConfirmed entry
belongs to, readLastConfirmed could not succeed, either open and openNoRecovery
would fail. (this issue has been reported in BOOKKEEPER-152, but it seems that
it is hard to separate into two patches. so I put them in this patch.)
so recovery tool needs failed bookies information as hints to tell
readLastConfirmed to skip failed bookies. I think to change excludedBookies
related api to protected, not expose to public.
what is your opinion?
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3472/#review4745
-----------------------------------------------------------
On 2012-01-29 09:58:30, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3472/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-29 09:58:30)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bookie recovery updates the ledger metadata in zookeeper. LedgerHandle
will not get notified of this update, so it will try to write out its own
ledger metadata, only to fail with KeeperException.BadVersion. This effectively
fences all write operations on the LedgerHandle (close and addEntry). close
will fail for obvious reasons. addEntry will fail once it gets to the failed
bookie in the schedule, tries to write, fails, selects a new bookie and tries
to update ledger metadata.
bq.
bq. Update Line 605, testSyncBookieRecoveryToRandomBookiesCheckForDupes(),
when done
bq. Also, uncomment addEntry in
TestFencing#testFencingInteractionWithBookieRecovery()
bq.
bq.
bq. This addresses bug BOOKKEEPER-112.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-112
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
5bb37c3
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
37623dc
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
547e240
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
b403aa1
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
56186ab
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
4625bbb
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
29070eb
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
43e999d
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
8526db5
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
015e4e4
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerOpenTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3472/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> Bookie Recovery on an open ledger will cause LedgerHandle#close on that
> ledger to fail
> --------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-112
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-112
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-112.patch, BOOKKEEPER-112.patch
>
>
> Bookie recovery updates the ledger metadata in zookeeper. LedgerHandle will
> not get notified of this update, so it will try to write out its own ledger
> metadata, only to fail with KeeperException.BadVersion. This effectively
> fences all write operations on the LedgerHandle (close and addEntry). close
> will fail for obvious reasons. addEntry will fail once it gets to the failed
> bookie in the schedule, tries to write, fails, selects a new bookie and tries
> to update ledger metadata.
> Update Line 605, testSyncBookieRecoveryToRandomBookiesCheckForDupes(), when
> done
> Also, uncomment addEntry in
> TestFencing#testFencingInteractionWithBookieRecovery()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
