[
https://issues.apache.org/jira/browse/BOOKKEEPER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203674#comment-13203674
]
[email protected] commented on BOOKKEEPER-137:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3661/#review4903
-----------------------------------------------------------
most is good to me. thanks Ivan, except a BookieException is missing in
BaseTestCase that I commented as below.
and it seems that new patch doesn't fix the readHeader twice problem.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
<https://reviews.apache.org/r/3661/#comment10799>
this patch applied to trunk would compile fail. due to in BOOKKEEPER-156,
start bookie action has been put in startBookie function. so it need to add
BookieException also in startBookie.
- Sijie
On 2012-02-07 18:13:15, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3661/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-07 18:13:15)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is an optimization to speed up the case where we have many ledgers
and are writing to them at random (a benchmark case we currently have).
Currently, we create the ledger index file and write the first 1k of it to disk
immediately. With a lot of ledgers being randomly written to, this means a lot
of random writes on the ledger disk. This fix postpones the creation of the
index file and writing of the first 1k until the first flush of the ledger.
bq.
bq. This patch includes BOOKKEEPER-136, as they both deal in the same area,
and I found it difficult to separate them.
bq.
bq. BOOKKEEPER-135 is not required for this patch, and will need modifications
after this goes in.
bq.
bq.
bq. This addresses bug BOOKKEEPER-137.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-137
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
99b797f
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
fa713c8
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
0fc5206
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
728d729
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
2228ab4
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
5706dd8
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
PRE-CREATION
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieLayoutVersionTest.java
c7b07e6
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
8526db5
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
db1a763
bq.
bq. Diff: https://reviews.apache.org/r/3661/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Do not create Ledger index files until absolutely necessary.
> ------------------------------------------------------------
>
> Key: BOOKKEEPER-137
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-137
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-137.diff, BOOKKEEPER-137.diff,
> BOOKKEEPER-137.diff, BOOKKEEPER-137.diff
>
>
> This is an optimization to speed up the case where we have many ledgers and
> are writing to them at random (a benchmark case we currently have).
> Currently, we create the ledger index file and write the first 1k of it to
> disk immediately. With a lot of ledgers being randomly written to, this means
> a lot of random writes on the ledger disk. This fix postpones the creation of
> the index file and writing of the first 1k until the first flush of the
> ledger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
