----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3661/#review4966 -----------------------------------------------------------
Ship it! thanks Ivan for explanation. the new patch is ok for me. +1 - Sijie On 2012-02-08 15:53:28, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3661/ > ----------------------------------------------------------- > > (Updated 2012-02-08 15:53:28) > > > Review request for bookkeeper. > > > Summary > ------- > > This is an optimization to speed up the case where we have many ledgers and > are writing to them at random (a benchmark case we currently have). > Currently, we create the ledger index file and write the first 1k of it to > disk immediately. With a lot of ledgers being randomly written to, this means > a lot of random writes on the ledger disk. This fix postpones the creation of > the index file and writing of the first 1k until the first flush of the > ledger. > > This patch includes BOOKKEEPER-136, as they both deal in the same area, and I > found it difficult to separate them. > > BOOKKEEPER-135 is not required for this patch, and will need modifications > after this goes in. > > > This addresses bug BOOKKEEPER-137. > https://issues.apache.org/jira/browse/BOOKKEEPER-137 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 8abe87a > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java > fa713c8 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java > 10ecac7 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java > 771c0ba > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java > 728d729 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java > 2228ab4 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java > 5706dd8 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java > ae63710 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieLayoutVersionTest.java > c7b07e6 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java > 8526db5 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java > 9750158 > > Diff: https://reviews.apache.org/r/3661/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
