[
https://issues.apache.org/jira/browse/BOOKKEEPER-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208511#comment-13208511
]
[email protected] commented on BOOKKEEPER-168:
----------------------------------------------------------
bq. On 2012-02-15 09:04:42, Sijie Guo wrote:
bq. > thanks Ivan. most of this patch is good to me, except two things.
bq. >
bq. > one is, you didn't update message bound when someone unsubscribes. is
there any decision on it?
bq. >
bq. > the other one is, if subscriber 1 subscribe topic with UNLIMITED bound,
subscriber 2 subscribe topic with size-bound, you treat it as size-bound. but
it would be better to set as UNLIMITED, right?
bq. one is, you didn't update message bound when someone unsubscribes. is
there any decision on it?
Well spotted, i've added this now
bq. the other one is, if subscriber 1 subscribe topic with UNLIMITED bound,
subscriber 2 subscribe topic with size-bound, you treat it as size-bound. but
it would be better to set as UNLIMITED, right?
Ah, there's a bug there also. I should break after finding a subscription with
no message bound.
bq. On 2012-02-15 09:04:42, Sijie Guo wrote:
bq. >
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java,
line 344
bq. > <https://reviews.apache.org/r/3824/diff/1/?file=73881#file73881line344>
bq. >
bq. > I think DEBUG level is better for such kind of message.
actually, i only had that in for testing. removed now.
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3824/#review5119
-----------------------------------------------------------
On 2012-02-09 16:57:20, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3824/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 16:57:20)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In hedwig, messages for a subscription will queue up forever if the
subscriber is offline. In some usecases, this is undesirable, as it will
eventually mean resource exhaustion. In this JIRA we propose an optional change
to the subscription contract, which allows the user to set a bound on the
number of messages which will be queued for its subscription while it is
offline.
bq.
bq.
bq. This addresses bug BOOKKEEPER-168.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-168
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-client/src/main/cpp/test/main.cpp 3290af3
bq. hedwig-client/src/main/cpp/test/messageboundtest.cpp PRE-CREATION
bq.
hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java
66e049f
bq.
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
5fb1d88
bq.
hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java
f46868b
bq. hedwig-client/src/main/cpp/inc/hedwig/client.h f37ef98
bq. hedwig-client/src/main/cpp/lib/client.cpp 6d70ad9
bq. hedwig-client/src/main/cpp/lib/data.h b4e2c15
bq. hedwig-client/src/main/cpp/lib/data.cpp a223120
bq. hedwig-client/src/main/cpp/lib/subscriberimpl.cpp 32075c4
bq. hedwig-client/src/main/cpp/scripts/tester.sh 5df613a
bq. hedwig-client/src/main/cpp/test/Makefile.am 62902e6
bq. hedwig-protocol/src/main/protobuf/PubSubProtocol.proto e44d981
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
2c9af4d
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
b76023c
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
02ec607
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/PersistenceManager.java
5c38ad9
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
0261521
bq.
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
714a631
bq.
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/MessageBoundedPersistenceTest.java
PRE-CREATION
bq.
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/StubPersistenceManager.java
84b866d
bq.
bq. Diff: https://reviews.apache.org/r/3824/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Message bounding on subscriptions
> ---------------------------------
>
> Key: BOOKKEEPER-168
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-168
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-168.diff
>
>
> In hedwig, messages for a subscription will queue up forever if the
> subscriber is offline. In some usecases, this is undesirable, as it will
> eventually mean resource exhaustion. In this JIRA we propose an optional
> change to the subscription contract, which allows the user to set a bound on
> the number of messages which will be queued for its subscription while it is
> offline.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
