[
https://issues.apache.org/jira/browse/BOOKKEEPER-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208548#comment-13208548
]
Hudson commented on BOOKKEEPER-170:
-----------------------------------
Integrated in bookkeeper-trunk #362 (See
[https://builds.apache.org/job/bookkeeper-trunk/362/])
BOOKKEEPER-170: Bookie constructor starts a number of threads. (ivank via
fpj) (Revision 1244528)
Result = ABORTED
fpj :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java
*
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConcurrentLedgerTest.java
> Bookie constructor starts a number of threads
> ---------------------------------------------
>
> Key: BOOKKEEPER-170
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-170
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-170.diff, BOOKKEEPER-170.diff
>
>
> Starting a thread in a constructor is bad[1]. Also, it makes unit testing on
> Bookie a bit of a pain. For this reason, i've refactored the thread starting
> code out, so that to start the bookie, you call start() like you usually have
> to for a thread anyhow. As a bonus, it fixes some findbugs issues.
> [1]
> http://stackoverflow.com/questions/84285/calling-thread-start-within-its-own-constructor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
