[
https://issues.apache.org/jira/browse/BOOKKEEPER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209532#comment-13209532
]
[email protected] commented on BOOKKEEPER-160:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/#review5162
-----------------------------------------------------------
In general the patch is good, but there's a few mods i'd like to see.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11305>
EntryLogMeta or EntryLogMetadata would be a better name as it only refers
to a single log of the entry logger.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11307>
Would it not be better to loop over entrySet rather than keySet here?
for (Map.Entry<Long, Etc> e : entryLogs2LedgersMap.entrySet()) {
}
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11310>
1024*1024 should be defined as a constant somewhere
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11309>
Shouldn't you throw an exception here?
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11308>
I don't like how EntryLogger is reaching back into Bookie to write the
entries. Also, I don't think it's necessary.
How I had imagined this working is that you create a new entry log to
compact into. You copy the entries across and then rename the file to the name
of the old entry log.
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
<https://reviews.apache.org/r/3874/#comment11298>
The defaults for the new options should be added to bk_server.conf in a
commented out fashion like other options.
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
<https://reviews.apache.org/r/3874/#comment11311>
I think we should run compaction based purely on the watermarks. Otherwise,
once we hit disk pressure, we'll have to run a lot of compaction at once.
- Ivan
On 2012-02-12 08:47:34, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3874/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-12 08:47:34)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. bookie server aggregates entries into entry log file. suppose there is
lots of ledgers, each ledger has little messages. so a entry log file would
contains messages from lots of different ledgers. if there is only one ledger
not be deleted, the entry log file would not be removed, whose occupied disk
space could not be reclaimed.
bq.
bq.
bq. This addresses bug BOOKKEEPER-160.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-160
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
57a6c29
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
42f54d2
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
0c83977
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java
PRE-CREATION
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
2e5d784
bq.
bq. Diff: https://reviews.apache.org/r/3874/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> bookie server needs to do compaction over entry log files to reclaim disk
> space
> -------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-160
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-160
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-160.patch
>
>
> bookie server aggregates entries into entry log file. suppose there is lots
> of ledgers, each ledger has little messages. so a entry log file would
> contains messages from lots of different ledgers. if there is only one ledger
> not be deleted, the entry log file would not be removed, whose occupied disk
> space could not be reclaimed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
