----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3910/#review5225 -----------------------------------------------------------
Looks good, I have a couple of minor comments. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java <https://reviews.apache.org/r/3910/#comment11422> Shouldn't this go into bookkeeper.tools? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java <https://reviews.apache.org/r/3910/#comment11433> Sounds like we need documentation for this. It is ok if we are adding in BOOKKEEPER-163. - fpj On 2012-02-15 14:08:46, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3910/ > ----------------------------------------------------------- > > (Updated 2012-02-15 14:08:46) > > > Review request for bookkeeper. > > > Summary > ------- > > Part of BOOKKEEPER-163. This improvement creates a framework to allow > administrators to upgrade the filesystem layout of previous bookkeeper > versions to be usable by the most recent software. The upgrade processes are > currently empty until BOOKKEEPER-163 adds something. > > > This addresses bug BOOKKEEPER-172. > https://issues.apache.org/jira/browse/BOOKKEEPER-172 > > > Diffs > ----- > > bookkeeper-server/bin/bookkeeper b0629bd > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3910/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
