-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/
-----------------------------------------------------------
(Updated 2012-03-03 08:07:49.773622)
Review request for bookkeeper.
Changes
-------
attach a new patch addressed Ivan's comment to separate minor & major
compaction into different threshold and interval to make them clearly.
Summary
-------
bookie server aggregates entries into entry log file. suppose there is lots of
ledgers, each ledger has little messages. so a entry log file would contains
messages from lots of different ledgers. if there is only one ledger not be
deleted, the entry log file would not be removed, whose occupied disk space
could not be reclaimed.
This addresses bug BOOKKEEPER-160.
https://issues.apache.org/jira/browse/BOOKKEEPER-160
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
23a1ffc
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
f661e90
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
aca66e6
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
51195d4
bookkeeper-server/conf/bk_server.conf d005d01
Diff: https://reviews.apache.org/r/3874/diff
Testing
-------
Thanks,
Sijie