----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4307/#review6029 -----------------------------------------------------------
hedwig-server/src/main/java/org/apache/hedwig/server/jmx/HedwigMBeanRegistry.java <https://reviews.apache.org/r/4307/#comment13011> This should extend BKMBeanRegistry to avoid copying Zookeeper code twice. - Ivan On 2012-03-13 11:32:54, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4307/ > ----------------------------------------------------------- > > (Updated 2012-03-13 11:32:54) > > > Review request for bookkeeper. > > > Summary > ------- > > we can extends / reuses zookeeper JMX utils to monitor and manage hedwig > server > > > This addresses bug BOOKKEEPER-96. > https://issues.apache.org/jira/browse/BOOKKEEPER-96 > > > Diffs > ----- > > > hedwig-server/src/main/java/org/apache/hedwig/server/jmx/HedwigJMXService.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/jmx/HedwigMBeanInfo.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/jmx/HedwigMBeanRegistry.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4307/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
