[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231253#comment-13231253
 ] 

[email protected] commented on BOOKKEEPER-97:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/#review6037
-----------------------------------------------------------

Ship it!


+1 looks fine to me.

- fpj


On 2012-03-13 11:36:29, Sijie Guo wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4308/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-13 11:36:29)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  collecting pub/sub/consume statistics on hub server and expose them thru 
JMX.
bq.  
bq.  the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing 
statistics thru JMX. 
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-97.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-97
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
 2c9af4d 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 
2573df0 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java
 1712027 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java
 PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java
 PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java
 7a785c4 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java
 f3b108a 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java
 09e8b92 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 
27e3104 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java
 PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java
 PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 
PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 
2f896d2 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
 0261521 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java
 PRE-CREATION 
bq.    
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4308/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Sijie
bq.  
bq.


                
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
>                 Key: BOOKKEEPER-97
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to