[ https://issues.apache.org/jira/browse/BOOKKEEPER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232569#comment-13232569 ]
jirapos...@reviews.apache.org commented on BOOKKEEPER-187: ---------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4403/ ----------------------------------------------------------- Review request for bookkeeper. Summary ------- Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors. This addresses bug BOOKKEEPER-187. https://issues.apache.org/jira/browse/BOOKKEEPER-187 Diffs ----- bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6e47c08 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java c514f6d bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java ba9c6d4 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java d14f373 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 87a1e66 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java 6e64932 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java c4eacda Diff: https://reviews.apache.org/r/4403/diff Testing ------- Thanks, Ivan > Create well defined interface for LedgerCache > --------------------------------------------- > > Key: BOOKKEEPER-187 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187 > Project: Bookkeeper > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 4.1.0 > > Attachments: BOOKKEEPER-187.diff > > > Currently the code reaches into LedgerCache to access FileInfos or read what > is in the cache without going through clean interfaces. This JIRA is to > define an interface for LedgerCache, so that we can reason about what > accesses are legal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira