> On 2012-03-19 12:07:58, Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java, > > line 175 > > <https://reviews.apache.org/r/4308/diff/1-2/?file=91622#file91622line175> > > > > Another typo here, thouls be incrementMessagesDelivered
ah, will fix it. > On 2012-03-19 12:07:58, Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java, > > line 260 > > <https://reviews.apache.org/r/4308/diff/1-2/?file=91624#file91624line260> > > > > This seems to be from another patch? diff 1 is old, diff 2 is newer, when you read diffs between 1 and 2, you saw this. actually it is not in the patch. - Sijie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4308/#review6068 ----------------------------------------------------------- On 2012-03-17 16:08:39, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4308/ > ----------------------------------------------------------- > > (Updated 2012-03-17 16:08:39) > > > Review request for bookkeeper. > > > Summary > ------- > > collecting pub/sub/consume statistics on hub server and expose them thru JMX. > > the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing > statistics thru JMX. > > > This addresses bug BOOKKEEPER-97. > https://issues.apache.org/jira/browse/BOOKKEEPER-97 > > > Diffs > ----- > > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java > f3b108a > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java > 09e8b92 > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java > 27e3104 > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java > PRE-CREATION > hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java > 7a785c4 > > hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java > 2c9af4d > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java > 2573df0 > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java > 1712027 > > hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java > 2f896d2 > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java > 5782bba > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4308/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
