----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4405/#review6113 -----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java <https://reviews.apache.org/r/4405/#comment13142> do you consider moving masterKeyCache into ledgerCache? it seems that would be more clear. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java <https://reviews.apache.org/r/4405/#comment13143> it seems that there is a reference counting in ledger handle before. but after refactoring, you remove it. so is it OK? - Sijie On 2012-03-19 11:43:51, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4405/ > ----------------------------------------------------------- > > (Updated 2012-03-19 11:43:51) > > > Review request for bookkeeper. > > > Summary > ------- > > Patch creates LedgerCache interface, and LedgerCacheImpl, which implements > the interface. LedgerCacheImpl's contains what LedgerCache did before the > change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, > but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors. > > > This addresses bug BOOKKEEPER-175. > https://issues.apache.org/jira/browse/BOOKKEEPER-175 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 6e47c08 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactory.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java > 87a1e66 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4405/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
